I've used a smoking character to help complete the "mysterious whistleblower" trope. It just wouldn't hit the same, not even in the 2020 setting, if he were vaping instead. I'd say it has its place, depending on what you're going for.
