I recently sent a short story to one of my old writing teachers. He replied with lots of praise (which made me very happy), but also pointed out that I really should have foreshadowed more. Basically to make readers go “oh!” at the end. The short story was about two men going up a mountain by horseback, talking about old days, and as they begin arguing, their past is revealed to the readers. Then when they finally make up, it turns out one of them is dead, hung himself, and the other one is up there to scatter his ashes and has imagined the whole conversation. So what my writing teacher meant was that the one character being dead kind of just comes out of no where. Thing is, I thought I did foreshadow some. Through the whole story, the one guy will ask the other if the spot they are at is nice, even when they are fighting. The other guy will always find something wrong with it until they get to the final spot. One is led to believe he's asking if this is a good place to set their camp, but is actually about where he wants his ashes scattered. But as I write it like that, it suddenly doesn't seem like foreshadowing anymore. But lets talk generally as well, do you think stories should have foreshadowing? Because I realized I never do it. Fantasy especially should probably have foreshadowing of some kind, and it's what I'm writing, yet there is nothing. My character who appears to be good through the whole story, but turns out to be evil right at the very end, is written like he was good the whole time. Maybe I want my readers to go WTF or something. I just want it to be a surprise. And in that case, him being evil kind of puts all the pieced together though. So what do you think? Do you foreshadow?